Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #159

Merged
merged 29 commits into from
Oct 13, 2023
Merged

Documentation #159

merged 29 commits into from
Oct 13, 2023

Conversation

Joel-Dahne
Copy link
Collaborator

I have been thinking about improving the state of the documentation for a while now. This is still very much work in progress but at least a starting point.

To run it locally you can follow the instructions from Documenter.jl. I do the following (I write it down mostly so I don't forget until next time): start a Julia REPL and activate the Arblib.jl repository, then run include("docs/make.jl"). I then run a local web server with python3 -m http.server --bind localhost.

It is the first time I create documentation for a Julia package and I have yet to figure out how to e.g. setup GitHub to build the documentation and such.

Any comments or ideas for the documentation are appreciated! I just wanted to get something started to have something to build on.

@kalmarek
Copy link
Owner

Hey, I've added the gh action for documentation; I'm not an expert though I just copied it from a different project that I created documentation for a long time ago ;)

@Joel-Dahne
Copy link
Collaborator Author

The main issue now is warnings for missing docs and cross references. Missing docs is not really a problem. Bit I haven't figure out how to handle the cross references. For example we reference Base.cconvert and it complains about not finding the docs for it. But it is a Base function so I don't know how to handle that.

@kalmarek
Copy link
Owner

The main issue now is warnings for missing docs and cross references. Missing docs is not really a problem. Bit I haven't figure out how to handle the cross references. For example we reference Base.cconvert and it complains about not finding the docs for it. But it is a Base function so I don't know how to handle that.

It is not possible to link to a method outside of the documented package. See e.g
JuliaDocs/Documenter.jl#1351
JuliaDocs/Documenter.jl#1343

In this regard rust generated docs are so much better...

@Joel-Dahne
Copy link
Collaborator Author

I have now removed some cross references and added the required documentation for some others. The only warnings remaining are for docs not included in the documentation, but these are mostly internal functions and I don't think it makes much sense to include them.

I also added documentation for the XLike types.

With this I think the documentation is "done". The most important parts are there, but it could certainly benefit from improvements at a later stage. The next step would be to actually deploy the documentation and link to it in the README. I'll see if I can figure out how that works!

@Joel-Dahne Joel-Dahne marked this pull request as ready for review October 6, 2023 10:22
@Joel-Dahne
Copy link
Collaborator Author

Okay, I think this might be ready now! We'll only really know if it works until we deploy it though...

@Joel-Dahne
Copy link
Collaborator Author

@kalmarek Could you approve this PR as well? Then I'll merge this and rebase the other one on this.

@kalmarek
Copy link
Owner

@Joel-Dahne Sorry it took me so long; I'm traveling right now ;)

@Joel-Dahne
Copy link
Collaborator Author

No worries at all! Lets hope that this works now!

@Joel-Dahne Joel-Dahne merged commit 7cc1342 into master Oct 13, 2023
13 checks passed
@Joel-Dahne Joel-Dahne deleted the documentation branch October 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants