Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/simple direct summand #40

Merged
merged 15 commits into from
Oct 18, 2021
Merged

Fix/simple direct summand #40

merged 15 commits into from
Oct 18, 2021

Conversation

kalmarek
Copy link
Owner

This reverts the "fix" I applied some time ago ;/

I realized that e.g. for abelian groups there aren't enough projections in the group ring (all of them are central), so it's (mathematically) not possible to realize minimal rank projection as an element of the group ring ;/ life is hard and sometimes math kicks :D

so, when χ is a complex irreducible character, for real affordable ψ = χ + conj(χ) we return semisimple projection. It should be possible to find the rank one projection numerically though, by noticing that image_basis(..., ψ) consists a multiple of 2-dimensional mutually orthogonal subspaces and we need to project on exactly one of them (or their sum, or whatever). I tried to do so numerically, but failed ;)

@blegat

@kalmarek kalmarek force-pushed the fix/simple_direct_summand branch from 13d1125 to d16405e Compare September 28, 2021 17:46
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #40 (6e16157) into master (dbbb167) will decrease coverage by 1.84%.
The diff coverage is 66.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   87.89%   86.04%   -1.85%     
==========================================
  Files          15       16       +1     
  Lines         958      982      +24     
==========================================
+ Hits          842      845       +3     
- Misses        116      137      +21     
Flag Coverage Δ
unittests 86.04% <66.17%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/matrix_projections.jl 91.91% <0.00%> (-3.88%) ⬇️
src/wedderburn_decomposition.jl 69.07% <61.76%> (-5.09%) ⬇️
src/actions.jl 83.33% <64.28%> (-5.96%) ⬇️
src/minimal_projections.jl 89.33% <85.71%> (-0.15%) ⬇️
src/sa_basis.jl 98.91% <100.00%> (+0.03%) ⬆️
src/util.jl 100.00% <100.00%> (ø)
src/direct_summands.jl 53.84% <0.00%> (-46.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbbb167...6e16157. Read the comment docs.

@kalmarek kalmarek force-pushed the fix/simple_direct_summand branch from d16405e to 6e16157 Compare September 28, 2021 22:26
@kalmarek kalmarek merged commit 9e23b8f into master Oct 18, 2021
@kalmarek kalmarek deleted the fix/simple_direct_summand branch October 18, 2021 14:10
@kalmarek kalmarek restored the fix/simple_direct_summand branch October 18, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant