-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/simple direct summand #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmarek
force-pushed
the
fix/simple_direct_summand
branch
from
September 28, 2021 17:46
13d1125
to
d16405e
Compare
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 87.89% 86.04% -1.85%
==========================================
Files 15 16 +1
Lines 958 982 +24
==========================================
+ Hits 842 845 +3
- Misses 116 137 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kalmarek
force-pushed
the
fix/simple_direct_summand
branch
from
September 28, 2021 22:26
d16405e
to
6e16157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the "fix" I applied some time ago ;/
I realized that e.g. for abelian groups there aren't enough projections in the group ring (all of them are central), so it's (mathematically) not possible to realize minimal rank projection as an element of the group ring ;/ life is hard and sometimes math kicks :D
so, when
χ
is a complex irreducible character, for real affordableψ = χ + conj(χ)
we return semisimple projection. It should be possible to find the rank one projection numerically though, by noticing thatimage_basis(..., ψ)
consists a multiple of2
-dimensional mutually orthogonal subspaces and we need to project on exactly one of them (or their sum, or whatever). I tried to do so numerically, but failed ;)@blegat