Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add numerical simple_projection + try_harder kwarg #41

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Nov 2, 2021

@blegat Let's meet and talk ;)

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #41 (d6efec0) into master (9e23b8f) will decrease coverage by 4.46%.
The diff coverage is 1.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   86.04%   81.58%   -4.47%     
==========================================
  Files          16       16              
  Lines         982     1037      +55     
==========================================
+ Hits          845      846       +1     
- Misses        137      191      +54     
Flag Coverage Δ
unittests 81.58% <1.81%> (-4.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/direct_summands.jl 10.60% <0.00%> (-43.25%) ⬇️
src/wedderburn_decomposition.jl 68.68% <50.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e23b8f...d6efec0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant