Skip to content

Commit

Permalink
fix(FEC-10598): add streamId to ad object (#481)
Browse files Browse the repository at this point in the history
Add streamId to Ad object.
Complements PR in playkit-js-ima-dai.
Fixes FEC-10598.
  • Loading branch information
SivanA-Kaltura authored Aug 17, 2021
1 parent 8a614d8 commit e70c741
Show file tree
Hide file tree
Showing 13 changed files with 1,180 additions and 1,374 deletions.
55 changes: 0 additions & 55 deletions dist/kaltura-ovp-player.cjs.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/kaltura-ovp-player.cjs.js.map

This file was deleted.

55 changes: 0 additions & 55 deletions dist/kaltura-ovp-player.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/kaltura-ovp-player.js.map

This file was deleted.

55 changes: 0 additions & 55 deletions dist/kaltura-tv-player.cjs.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/kaltura-tv-player.cjs.js.map

This file was deleted.

55 changes: 0 additions & 55 deletions dist/kaltura-tv-player.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/kaltura-tv-player.js.map

This file was deleted.

66 changes: 39 additions & 27 deletions docs/ads.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,16 +284,18 @@ You can observe the following timeline diagram that simulates these events' exac
- [height][19]
- [bitrate][20]
- [skippable][21]
- [AdsController][22]
- [Parameters][23]
- [allAdsCompleted][24]
- [isAdBreak][25]
- [getAdBreaksLayout][26]
- [getAdBreak][27]
- [getAd][28]
- [skipAd][29]
- [playAdNow][30]
- [Parameters][31]
- [vpaid][22]
- [streamId][23]
- [AdsController][24]
- [Parameters][25]
- [allAdsCompleted][26]
- [isAdBreak][27]
- [getAdBreaksLayout][28]
- [getAdBreak][29]
- [getAd][30]
- [skipAd][31]
- [playAdNow][32]
- [Parameters][33]
## <a name="AdBreak"></a>AdBreak
Expand Down Expand Up @@ -374,7 +376,15 @@ Returns **[string][32]** - The ad bitrate.
### skippable
Returns **[string][32]** - Whether the ad is skippable or not.
Returns **[boolean][33]** - Whether the ad is skippable or not.
### vpaid
Returns **[boolean][33]** - Whether the ad is vpaid or not.
### streamId
Returns **[string][32]** - The ad streamId.
## <a name="AdsController"></a>AdsController
Expand Down Expand Up @@ -440,19 +450,21 @@ Returns **void**
[19]: #height
[20]: #bitrate
[21]: #skippable
[22]: #adscontroller
[23]: #parameters-2
[24]: #alladscompleted
[25]: #isadbreak
[26]: #getadbreakslayout
[27]: #getadbreak
[28]: #getad
[29]: #skipad
[30]: #playadnow
[31]: #parameters-3
[32]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String
[33]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean
[34]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array
[35]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Number
[36]: #adbreak
[37]: #ad
[22]: #vpaid
[23]: #streamid
[24]: #adscontroller
[25]: #parameters-2
[26]: #alladscompleted
[27]: #isadbreak
[28]: #getadbreakslayout
[29]: #getadbreak
[30]: #getad
[31]: #skipad
[32]: #playadnow
[33]: #parameters-3
[34]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String
[35]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean
[36]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array
[37]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Number
[38]: #adbreak
[39]: #ad
Loading

0 comments on commit e70c741

Please sign in to comment.