Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10598): add streamId to ad object #481

Merged
merged 16 commits into from
Aug 17, 2021
Merged

fix(FEC-10598): add streamId to ad object #481

merged 16 commits into from
Aug 17, 2021

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Aug 16, 2021 •
edited
Loading

Description of the Changes

Add streamId to Ad object.
Complements PR in playkit-js-ima-dai.
Fixes FEC-10598.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura requested a review from a team August 16, 2021 08:42
yairans
yairans previously approved these changes Aug 17, 2021
View reviewed changes
@SivanA-Kaltura SivanA-Kaltura merged commit e70c741 into master Aug 17, 2021
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-10598-expose-stream-id branch August 17, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @yairans