Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9629): Player is not inline when rendered after the DOM loads #302

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix(FEC-9629): Player is not inline when rendered after the DOM loads #302

merged 1 commit into from
Jan 30, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 30, 2020 •
edited
Loading

Description of the Changes

Set the autoplay capability to false for native Ios player.
Thanks kaltura/playkit-js#438 the runCapability won't run

Solves FEC-9629

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team January 30, 2020 10:02
@yairans yairans self-assigned this Jan 30, 2020
@shalomm-gloat shalomm-gloat mentioned this pull request Jan 30, 2020
Merged
5 tasks
@yairans yairans mentioned this pull request Jan 30, 2020
Merged
5 tasks
@yairans yairans merged commit cdd85d0 into master Jan 30, 2020
@yairans yairans deleted the FEC-9629 branch January 30, 2020 10:47
yairans pushed a commit to kaltura/playkit-js that referenced this pull request Jan 30, 2020
fix(FEC-9629): Player is not inline when rendered after the DOM loads (…
13f36b5 
…#439)

This reverts commit 1b4a3ca as is unneeded any more due to kaltura/kaltura-player-js#302

Solves FEC-9629
yairans added a commit to kaltura/playkit-js-ima that referenced this pull request Jan 30, 2020
@yairans
fix(FEC-9629): Player is not inline when rendered after the DOM loads (…
0cada33 
…#158)

This reverts commit 37af209 as is unneeded any more due to kaltura/kaltura-player-js#302

Solves FEC-9629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe