fix(FEC-9577): Hisense playback doesn't work #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisense can't contain base64 as source.
extract the capability relevant element from json on setCapability and add implemention on the the capability element
yairans
suggested changes
Jan 28, 2020
src/player.js
Outdated
| Player._playerCapabilities[engineType] = Utils.Object.mergeDeep({}, Player._playerCapabilities[engineType], capabilities); | ||
| EngineProvider.getEngines() | ||
| .find(Engine => Engine.id === engineType) | ||
| .setCapabilities(capabilities); |
| ? Promise.resolve(playCapability) | ||
| : Html5AutoPlayCapability.runCapability(playsinline); | ||
| return fallbackPlayCapabilityTest.then(fallbackPlayCapability => | ||
| Utils.Object.mergeDeep(fallbackPlayCapability, Html5AutoPlayCapability._capabilities) |
There was a problem hiding this comment.
Does this merge pass by the returned promise?
yairans
approved these changes
Jan 29, 2020
Merged
5 tasks
yairans
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Jan 30, 2020
…#302) Set the autoplay capability to `false` for native Ios player. Thanks kaltura/playkit-js#438 the `runCapability` won't run Solves FEC-9629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: Hisense can't contain base64 as source.
Solution: add the set capability to engines and then handle it inside the engines, add partial possibility assignment the rest capability will be checked as well, if not needed it won't check.
add regex to detect correctly hisense TV and add smart tv detection fallback for tv which doesn't support yet.
Depends on kaltura/kaltura-player-js#298
Solves FEC-9577
CheckLists