feat(FEC-10656): set forceRedirectExternalStreams as true by default on IE11 and Chromecast #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
5 tasks
OrenMe
reviewed
Nov 25, 2020
src/ovp/player-defaults.js
Outdated
| */ | ||
| export function getDefaultRedirectOptions(options: KPOptionsObject): Object { | ||
| const configObj = {}; | ||
| if (Env.browser.name === 'IE' || Env.device.model === 'Chromecast') { |
OrenMe
reviewed
Nov 25, 2020
src/ovp/player-defaults.js
Outdated
| if (typeof forceRedirectExternalStreams !== 'boolean') { | ||
| configObj.sources = { | ||
| options: { | ||
| forceRedirectExternalStreams: true |
There was a problem hiding this comment.
if sources handler wasn't passed set the default one
OrenMe
suggested changes
Nov 25, 2020
OrenMe
reviewed
Nov 25, 2020
src/ovp/player-defaults.js
Outdated
Comment on lines
20
to
55
|
|
||
| /** | ||
| * JSONP handler function, returns the direct manifest uri. | ||
| * @private | ||
| * @param {Object} data - The json object that returns from the server. | ||
| * @param {string} uri - Original request uri. | ||
| * @returns {string} - The direct uri. | ||
| */ | ||
| function getDirectManifestUri(data: Object, uri: string): string { | ||
| const getHostName = uri => { | ||
| const parser = document.createElement('a'); | ||
| parser.href = uri; | ||
| return parser.hostname; | ||
| }; | ||
| // if the json contains one url, it means it is a redirect url. if it contains few urls, it means its the flavours | ||
| // so we should use the original url. | ||
| const uriHost = getHostName(uri); | ||
| let hasOneFlavor = false; | ||
| let redirectedUriHost = ''; | ||
| let redirectedUri = ''; | ||
| if (data) { | ||
| if (data.flavors && Array.isArray(data.flavors)) { | ||
| hasOneFlavor = data.flavors.length === 1; | ||
| redirectedUriHost = hasOneFlavor && getHostName(data.flavors[0].url); | ||
| redirectedUri = data.flavors[0].url; | ||
| } else if (data.result) { | ||
| hasOneFlavor = true; | ||
| redirectedUriHost = getHostName(data.result.url); | ||
| redirectedUri = data.result.url; | ||
| } | ||
| } | ||
| if (hasOneFlavor && uriHost !== redirectedUriHost) { | ||
| return redirectedUri; | ||
| } | ||
| return uri; | ||
| } |
There was a problem hiding this comment.
suggest we keep this in original file if only for sake of git history.
5 tasks
yairans
added a commit
that referenced
this pull request
Dec 6, 2020
Issue: #370 [moved](https://github.com/kaltura/kaltura-player-js/pull/370/files#diff-b20fda8cac0288af75e0f3c4304df5420584de585d923934f9606e3634d2dbf5L302) the redirect default settings from `setup` to `loadMedia` so `sources` could be `undefined` in kaltura-player constructor Solution: pass empty object to `sources` to the local player if it's `undefined` Solves FEC-10749
5 tasks
5 tasks
yairans
added a commit
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
implement
getDefaultRedirectOptionsin ovp and ott player (void impl in ott)Solves FEC-10656, KMS-22502
CheckLists