-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-10656): set forceRedirectExternalStreams as true by default on IE11 and Chromecast #370
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f5c419e
feat(FEC-10656): set forceRedirectExternalStreams as true by default …
yairans 9f81979
rename
yairans 5f35ca7
add chromecast
yairans ffa01b3
add tests
yairans 0dc3737
merge master
yairans 35b533b
support change media
yairans 7c3de60
keep external file for the handler
yairans 0bc2b00
Merge branch 'master' into FEC-10656
yairans e756ff8
eslint
yairans 3efc113
Merge remote-tracking branch 'origin/FEC-10656' into FEC-10656
yairans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
import {getDefaultRedirectOptions} from './../../../src/ovp/player-defaults'; | ||
import {Env, MediaType} from '@playkit-js/playkit-js'; | ||
|
||
describe('getDefaultRedirectOptions', function () { | ||
let sandbox; | ||
beforeEach(function () { | ||
sandbox = sinon.createSandbox(); | ||
}); | ||
|
||
afterEach(function () { | ||
sandbox.restore(); | ||
}); | ||
describe('forceRedirectExternalStreams', function () { | ||
it('should return void for vod on ie11', function () { | ||
sandbox.stub(Env, 'browser').get(() => ({name: 'IE'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.VOD}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void for vod on chromecast', function () { | ||
sandbox.stub(Env, 'device').get(() => ({model: 'Chromecast'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.VOD}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void for live chrome', function () { | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.LIVE}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return true for live on ie11', function () { | ||
sandbox.stub(Env, 'browser').get(() => ({name: 'IE'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.LIVE}}); | ||
defaultConfig.sources.options.forceRedirectExternalStreams.should.be.true; | ||
}); | ||
|
||
it('should return true for live on chromecast', function () { | ||
sandbox.stub(Env, 'device').get(() => ({model: 'Chromecast'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.LIVE}}); | ||
defaultConfig.sources.options.forceRedirectExternalStreams.should.be.true; | ||
}); | ||
|
||
it('should return void for live on ie11 if already configured on player config', function () { | ||
sandbox.stub(Env, 'browser').get(() => ({name: 'IE'})); | ||
const defaultConfig = getDefaultRedirectOptions({sources: {options: {forceRedirectExternalStreams: false}}}, {sources: {type: MediaType.LIVE}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void for live on ie11 if already configured on media config', function () { | ||
sandbox.stub(Env, 'browser').get(() => ({name: 'IE'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.LIVE, options: {forceRedirectExternalStreams: false}}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void for live on chromecast if already configured on player config', function () { | ||
sandbox.stub(Env, 'device').get(() => ({model: 'Chromecast'})); | ||
const defaultConfig = getDefaultRedirectOptions({sources: {options: {forceRedirectExternalStreams: false}}}, {sources: {type: MediaType.LIVE}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void for live on chromecast if already configured on media config', function () { | ||
sandbox.stub(Env, 'device').get(() => ({model: 'Chromecast'})); | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {type: MediaType.LIVE, options: {forceRedirectExternalStreams: false}}}); | ||
(defaultConfig.sources.options.forceRedirectExternalStreams === undefined).should.be.true; | ||
}); | ||
}); | ||
|
||
describe('redirectExternalStreamsHandler', function () { | ||
it('should return the default', function () { | ||
const defaultConfig = getDefaultRedirectOptions({}); | ||
(typeof defaultConfig.sources.options.redirectExternalStreamsHandler === 'function').should.be.true; | ||
}); | ||
|
||
it('should return void if already configured on player config', function () { | ||
const defaultConfig = getDefaultRedirectOptions({sources: {options: {redirectExternalStreamsHandler: () => {}}}}); | ||
(defaultConfig.sources === undefined).should.be.true; | ||
}); | ||
|
||
it('should return void if already configured on media config', function () { | ||
const defaultConfig = getDefaultRedirectOptions({}, {sources: {options: {redirectExternalStreamsHandler: () => {}}}}); | ||
(defaultConfig.sources === undefined).should.be.true; | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest we keep this in original file if only for sake of git history.