-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-11761): expose stream timed metadata - phase 2 #512
Conversation
ts-typed/cue-point-manager.d.ts
Outdated
export interface CuePointManager { | ||
getAllCuePoints(): Array<VTTCue>; | ||
getAllCuePoints(): Array<CuePoint>; | ||
getActiveCuePoints(): Array<VTTCue>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getActiveCuePoints returns Array<CuePoint>
@@ -25,25 +19,27 @@ export class CuePointManager { | |||
} | |||
|
|||
_createTextTrackCue(data: CuePoint): TextTrackCue { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we not using the "private" indication here when methods are internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is "private" indication?
use `CuePoint` from `TIMED_METADATA_CHANGE` instead of `VttCue` from `TIMED_METADATA` Depends on kaltura/kaltura-player-js#512
use `CuePoint` from `TIMED_METADATA_CHANGE` instead of `VttCue` from `TIMED_METADATA` Depends on kaltura/kaltura-player-js#512
pass `CuePoint` to addCuePoints api Depends on kaltura/kaltura-player-js#512
Description of the Changes
use
TimedMetadata
from coreChange cuePointManager API's to use
TimedMetadata
instead ofVttCue
Solves FEC-11761
Depends on kaltura/playkit-js#623
Breaking Change for -
kaltura/playkit-js-dual-screen#52
kaltura/playkit-js-kaltura-cuepoints#15
CheckLists