feat(FEC-11761): expose stream timed metadata - phase 2 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semarche-kaltura
previously approved these changes
Jan 10, 2022
This was referenced Jan 11, 2022
semarche-kaltura
requested changes
Jan 11, 2022
src/image-sync-manager.ts
Outdated
| @@ -64,16 +53,16 @@ export class ImageSyncManager { | |||
| this._imagePlayer.preLoadImages(); | |||
| }; | |||
|
|
|||
| private _onTimedMetadata = () => { | |||
| private _onTimedMetadataChange = ({payload}: TimedMetadata) => { | |||
| // TODO: use single "metadata" TextTrack once cue-point manager become use it | |||
There was a problem hiding this comment.
let's remove the TODO cause active cue-points already comes from payload of TIMED_METADATA_CHANGE event
semarche-kaltura
previously approved these changes
Jan 11, 2022
yairans
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Jan 12, 2022
use `TimedMetadata` from core Change cuePointManager API's to use `TimedMetadata` instead of `VttCue` Solves FEC-11761 Depends on kaltura/playkit-js#623 Breaking Change for - kaltura/playkit-js-dual-screen#52 kaltura/playkit-js-kaltura-cuepoints#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
CuePointfromTIMED_METADATA_CHANGEinstead ofVttCuefromTIMED_METADATADepends on kaltura/kaltura-player-js#512
Deleted and pushed by #53