Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-11875): Related Entries - by context #523

Merged
merged 22 commits into from
Mar 2, 2022

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Feb 3, 2022

Description of the Changes

Update player type signature to support usage in related entries plugin

Resolves FEC-11875
Related PRs:
kaltura/playkit-js-related#4
kaltura/playkit-js-providers#171

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans previously approved these changes Feb 7, 2022
yairans
yairans previously approved these changes Feb 8, 2022
ts-typed/player.d.ts Outdated Show resolved Hide resolved
ts-typed/kaltura-player.d.ts Outdated Show resolved Hide resolved
yairans
yairans previously approved these changes Feb 23, 2022
yairans pushed a commit to kaltura/playkit-js-providers that referenced this pull request Mar 2, 2022
@@ -27,8 +27,7 @@ declare namespace KalturaPlayerTypes {
}

export enum EntryTypes {
Vod = 'Vod',
Live = 'Live',
Vod = 'Vod'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Live has been removed?

yairans pushed a commit to kaltura/playkit-js-related that referenced this pull request Mar 2, 2022
@yairans yairans changed the title feat(FEC-11875): Related Entries - Phase 2 feat(FEC-11875): Related Entries - by context Mar 2, 2022
@yairans yairans merged commit 86fe909 into master Mar 2, 2022
@yairans yairans deleted the FEC-11875-related-grid-p2 branch March 2, 2022 11:37
borhandarabi pushed a commit to TasvirChi/playchi-js-providers that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants