feat(FEC-11875): Related Entries - by context #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
suggested changes
Feb 2, 2022
src/components/pre-playback-play-overlay-wrapper/pre-playback-play-overlay-wrapper.tsx
Outdated
Show resolved
Hide resolved
5 tasks
yairans
suggested changes
Feb 7, 2022
| @@ -57,11 +56,17 @@ | |||
| left: 4px; | |||
| padding: 2px; | |||
| position: absolute; | |||
|
|
|||
| &.live { | |||
| background-color: #e12437; | |||
There was a problem hiding this comment.
export $live-color from UI and use it
There was a problem hiding this comment.
it's not the same color as the Figma spec, live-color is #da1f26
There was a problem hiding this comment.
As i saw in the css inspector it's different code but same color. Do you see a difference?
yairans
reviewed
Feb 7, 2022
yairans
reviewed
Feb 7, 2022
yairans
reviewed
Feb 8, 2022
5 tasks
yairans
suggested changes
Feb 23, 2022
|
@yairans loadMedia also calls configure, which means to not call load twice I need to understand if it was called by loadMedia or not. So for now I'll just ignore updateConfig. |
yairans
suggested changes
Mar 1, 2022
add ks to useContext add webpack dev server
yairans
pushed a commit
to kaltura/playkit-js-providers
that referenced
this pull request
Mar 2, 2022
Export OVPProviderParser. Resolves [FEC-11875](https://kaltura.atlassian.net/browse/FEC-11875) Related PRs: kaltura/playkit-js-related#4 kaltura/kaltura-player-js#523
yairans
changed the title
yairans
pushed a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Mar 2, 2022
Update player type signature to support usage in related entries plugin Resolves FEC-11875 Related PRs: kaltura/playkit-js-related#4 kaltura/playkit-js-providers#171
borhandarabi
pushed a commit
to TasvirChi/playchi-js-providers
that referenced
this pull request
May 14, 2024
Export OVPProviderParser. Resolves [FEC-11875](https://kaltura.atlassian.net/browse/FEC-11875) Related PRs: kaltura/playkit-js-related#4 kaltura/kaltura-player-js#523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Bug Fixes
Responsivity
Additional functionality
Resolves FEC-11875
Related PRs:
kaltura/kaltura-player-js#523
kaltura/playkit-js-providers#171
WIP
CheckLists