Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-7089): call player.reset() before change media #104

Merged
merged 3 commits into from
Mar 27, 2018
Merged

feat(FEC-7089): call player.reset() before change media #104

merged 3 commits into from
Mar 27, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 27, 2018 •
edited
Loading

Description of the Changes

Call player reset API before changing media.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 27, 2018
@dan-ziv dan-ziv requested a review from OrenMe March 27, 2018 13:49
OrenMe
OrenMe previously approved these changes Mar 27, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit c6cbfb3 into master Mar 27, 2018
@dan-ziv dan-ziv deleted the FEC-8079 branch March 27, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe