Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8349): OTT analytics - no event send for logged user #134

Merged
merged 3 commits into from
Jun 25, 2018
Merged

fix(FEC-8349): OTT analytics - no event send for logged user #134

merged 3 commits into from
Jun 25, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 25, 2018 •
edited
Loading

Description of the Changes

  • evaluate false and 0 values
  • parse string to boolean and number when applicable ("false", "1" etc.)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jun 25, 2018
dan-ziv
dan-ziv previously approved these changes Jun 25, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit f3e1766 into master Jun 25, 2018
@dan-ziv dan-ziv deleted the FEC-8349 branch June 25, 2018 12:46
@yairans yairans mentioned this pull request Jul 2, 2018
Merged
5 tasks
yairans added a commit that referenced this pull request Jul 2, 2018
@yairans
chore: fix destroy test (#141)
9593689 
revert removing destroy from test #134
as it fixed by kaltura/playkit-js-ui#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @dan-ziv