Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9013): [iOS] - Player doesnt play ads native when playsinline is false #234

Merged
merged 1 commit into from
Apr 3, 2019
Merged

fix(FEC-9013): [iOS] - Player doesnt play ads native when playsinline is false #234

merged 1 commit into from
Apr 3, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Apr 3, 2019

Description of the Changes

set default value in ima plugin (kaltura/playkit-js-ima#103) instead in kaltura player.
delayInitUntilSourceSelected will be set to true always by default.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans merged commit 60edaf6 into master Apr 3, 2019
@yairans yairans deleted the FEC-9013 branch April 3, 2019 14:48
@yairans yairans changed the title fix(FEC-9013): [iOS] - Player doesnt play ads native fix(FEC-9013): [iOS] - Player doesnt play ads native when playsinline is false Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @Yuvalke