Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8212): support modular build process #265

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Aug 7, 2019

Description of the Changes

This PR will enable building the kaltura player as a modular bundle allowing to choose which packages are added to the bundle.
In order to allow this all dependencies were removed and are now subject to the application building the player to add them.
The kaltura player is now only the "convenience" wrapper project that allows doing complex operations with single methods(i.e. call loadMedia calls provider, parses and response, checks for errors, set config and evaluates tokens and then loads playkit).
This will allow to move the responsibility to choose dependencies in the bundler and remove unused packages from the payload, which will lead to smaller bundle and faster load times etc.
This will also enable us to hook the project to our generic CI/CD pipe and deploy passing builds on the fly to the staging area.

Need to:

  • Handle Shaka expose for DTG
  • Generate docs
  • Docs for new register methods

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe requested a review from yairans August 7, 2019 07:29
@OrenMe OrenMe self-assigned this Aug 7, 2019
src/common/provider-manager.js Outdated Show resolved Hide resolved
src/common/utils/setup-helpers.js Outdated Show resolved Hide resolved
@@ -5,27 +5,156 @@
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">
<title>Title</title>
<link rel="stylesheet" type="text/css" href="./style.css"/>
<script src="./kaltura-ovp-player.js" type="text/javascript"></script>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this file

src/index.js Show resolved Hide resolved
src/kaltura-player.js Outdated Show resolved Hide resolved
test/src/common/poster.spec.js Outdated Show resolved Hide resolved
test/src/common/poster.spec.js Outdated Show resolved Hide resolved
src/kaltura-player.js Show resolved Hide resolved
src/common/ui-wrapper.js Show resolved Hide resolved
test/src/kaltura-player.spec.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants