Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ads-controller): sources.startTime isn't always exists and can change from source to source #399

Merged
merged 1 commit into from
Jan 17, 2021
Merged

fix(ads-controller): sources.startTime isn't always exists and can change from source to source #399

merged 1 commit into from
Jan 17, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 17, 2021

Description of the Changes

sources.startTime isn't always exists before sources received in the player and also can change from source to source.
Handle the configured ad breaks on SOURCE_SELECTED instead on PLAYER_RESET.

related to FEC-10686.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 17, 2021
@dan-ziv dan-ziv changed the title fix(AdsController): sources.startTime isn't always exists and can change from source to source fix(ads-controller): sources.startTime isn't always exists and can change from source to source Jan 17, 2021
@dan-ziv dan-ziv merged commit 3965295 into master Jan 17, 2021
@dan-ziv dan-ziv deleted the FEC-10686-patch branch January 17, 2021 14:25
@dan-ziv dan-ziv restored the FEC-10686-patch branch January 17, 2021 14:25
@dan-ziv dan-ziv deleted the FEC-10686-patch branch January 17, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-ziv @OrenMe @yairans