Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove thumbnail height from thumbnail service call #421

Merged
merged 2 commits into from
Mar 3, 2021
Merged

fix: remove thumbnail height from thumbnail service call #421

merged 2 commits into from
Mar 3, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 3, 2021

Description of the Changes

remove thumbnail height from thumbnail service call due to BE cache issues.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from yairans March 3, 2021 09:56
@dan-ziv dan-ziv self-assigned this Mar 3, 2021
yairans
yairans previously approved these changes Mar 3, 2021
View reviewed changes
@dan-ziv dan-ziv merged commit 9611685 into master Mar 3, 2021
@dan-ziv dan-ziv deleted the remove-thumbnail-height-from-service-call branch March 3, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @yairans