feat(FEC-11632): expose stream timed metadata #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2021
semarche-kaltura
previously approved these changes
Dec 14, 2021
yairans
added a commit
to kaltura/playkit-js
that referenced
this pull request
Dec 16, 2021
add a new api `getTextTracks` to get the native video text tracks add a new type `TextTrackCue` add a new class `CuePoint` and `CuePoint.TYPE` - `EMSG` for emsg and `CUSTOM` for custom cue points add a new function `createTextTrackCue` to create `TextTrackCue` for a `CuePoint` Related to kaltura/kaltura-player-js#509, kaltura/playkit-js-dash#172 Solves FEC-11632
yairans
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
Dec 16, 2021
listen to shaka 'emsg' event push the emsg detail as cue point to a metadata track for `TIMED_METADATA` to be fired in time fired `TIMED_METADATA_ADDED` ith the cue point Depends on kaltura/playkit-js#618 Related to kaltura/kaltura-player-js#509 Solves FEC-11632
borhandarabi
pushed a commit
to TasvirChi/playchi-js-dash
that referenced
this pull request
May 14, 2024
listen to shaka 'emsg' event push the emsg detail as cue point to a metadata track for `TIMED_METADATA` to be fired in time fired `TIMED_METADATA_ADDED` ith the cue point Depends on kaltura/playkit-js#618 Related to kaltura/kaltura-player-js#509 Solves FEC-11632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add a new api
getTextTracksin cue point manager use
createTextTrackCuefrom corechange all cue point manager api's to consider all metadata tracks
Depends on kaltura/playkit-js#618
Related to kaltura/playkit-js-dash#172
Solves FEC-11632
CheckLists