Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove kanalytics base url #54

Merged
merged 2 commits into from
Oct 31, 2017
Merged

fix: remove kanalytics base url #54

merged 2 commits into from
Oct 31, 2017

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 31, 2017 •
edited
Loading

Description of the Changes

kanalytics already declares own default base url
https://github.com/kaltura/playkit-js-kanalytics/blob/631d9b5e18dc66585e568baccd7cd867eb6e138b/src/kanalytics.js#L19
no need declaring it here

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Oct 31, 2017
@OrenMe OrenMe merged commit d6c0251 into master Oct 31, 2017
@yairans yairans deleted the FEC-7388 branch October 31, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe