Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12562): Ignore ks configuration on kava plugin incase of ottAnalytics exists on player #574

Merged
merged 17 commits into from
Sep 22, 2022
Merged

fix(FEC-12562): Ignore ks configuration on kava plugin incase of ottAnalytics exists on player #574

merged 17 commits into from
Sep 22, 2022

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Sep 20, 2022 •
edited
Loading

Description of the Changes
Ignore ks configuration on kava plugin incase of ottAnalytics exists on player

solves: FEC-12562

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@giladna giladna changed the title Fec 12562 1 fix(FEC-12562) - ignore ks configuration on kava plugin incase of ottAnalytics exists on player Sep 20, 2022
@giladna giladna changed the title fix(FEC-12562) - ignore ks configuration on kava plugin incase of ottAnalytics exists on player fix(FEC-12562) - Ignore ks configuration on kava plugin incase of ottAnalytics exists on player Sep 20, 2022
SivanA-Kaltura
SivanA-Kaltura requested changes Sep 21, 2022
View reviewed changes
src/index_ott.html Outdated Show resolved Hide resolved
src/ott/plugins/plugins-config-store.js Outdated Show resolved Hide resolved
src/ovp/plugins/plugins-config-store.js Outdated Show resolved Hide resolved
@SivanA-Kaltura SivanA-Kaltura changed the title fix(FEC-12562) - Ignore ks configuration on kava plugin incase of ottAnalytics exists on player fix(FEC-12562): Ignore ks configuration on kava plugin incase of ottAnalytics exists on player Sep 21, 2022
@giladna giladna merged commit b01430b into master Sep 22, 2022
@giladna giladna deleted the FEC-12562_1 branch September 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladna @SivanA-Kaltura