Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12527): turning on hls debug mode in config causes the player to crash #176

Merged
merged 2 commits into from
Sep 4, 2022

Conversation

SivanA-Kaltura
Copy link
Contributor

Description of the Changes

In some cases hls.js triggers our event handlers (specifically _onAudioTrackSwitched) before the _onManifestLoaded handler. When _onAudioTracksSwitched calls _playerTracks.find, which is undefined, it crashes.
The solution is to initialize _playerTracks with an empty array before _onManifestLoaded fills it with the real values.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit 78793b4 into master Sep 4, 2022
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-12527-fix-hls-debug-error branch September 4, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants