Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serve ima as external bundle #61

Merged
merged 1 commit into from
May 10, 2018
Merged

feat: serve ima as external bundle #61

merged 1 commit into from
May 10, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 9, 2018 •
edited
Loading

Description of the Changes

align with the new bundles mechanism

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this May 9, 2018
@yairans yairans requested review from OrenMe and dan-ziv May 9, 2018 14:26
@yairans yairans mentioned this pull request May 9, 2018
Merged
5 tasks
yairans added a commit to kaltura/kaltura-player-js that referenced this pull request May 10, 2018
@yairans
feat: remove youbora & ima plugins from kaltura player bundle (#120)
9cc5766 
These plugins are served as external bundle
kaltura/playkit-js-youbora#20
kaltura/playkit-js-ima#61
@yairans yairans merged commit 43de7c5 into master May 10, 2018
@yairans yairans deleted the external-bundle branch May 10, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedhutzler odedhutzler odedhutzler approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @odedhutzler