Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9156): getting bumper from playback context #91

Merged
merged 4 commits into from
Jul 10, 2019
Merged

feat(FEC-9156): getting bumper from playback context #91

merged 4 commits into from
Jul 10, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 7, 2019 •
edited
Loading

Description of the Changes

  • Parse the bumper comes from the provider (OTT only)
  • Add it to the plugins passed to the player

Depends on kaltura/kaltura-player-js#252

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team July 7, 2019 09:52
@yairans yairans self-assigned this Jul 7, 2019
@yairans yairans changed the title feat(FEC-9156): getting bumper from playback context (OTT) feat(FEC-9156): getting bumper from playback context Jul 7, 2019
@yairans yairans merged commit de7c668 into master Jul 10, 2019
@yairans yairans deleted the FEC-9156 branch July 10, 2019 10:27
OrenMe pushed a commit that referenced this pull request Aug 27, 2019
@yairans @OrenMe
cherry-pick #91
499001f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe