Skip to content

Commit

Permalink
fix(FEC-13632): Divert the kaltura-player-js types to be imported loc…
Browse files Browse the repository at this point in the history
…ally and not form node_modules (circular deps) (#841)

### Description of the Changes

 Remove kaltura-player-js dep

**Issue:** kaltura player github `actions faild since it depend on
playkit-ui types which in turn depend on kaltura-player... and so on..
and on and on... Jesus Christ...
Apparently it used by e2e tests... 
restored

**Fix:** dependency should not depend on dependent.... (this is also a
general rule for life...)

#### Resolves FEC-FEC-13632

Related Prs: 
kaltura/kaltura-player-js#690

---------

Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
  • Loading branch information
JonathanTGold and JonathanTGold authored Jan 9, 2024
1 parent 8ddc9e5 commit 1a5779a
Show file tree
Hide file tree
Showing 15 changed files with 2,908 additions and 15 deletions.
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
src/types/kaltura-player-js.d.ts
p
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@babel/preset-typescript": "^7.23.3",
"@microsoft/api-extractor": "^7.38.0",
"@playkit-js/browserslist-config": "^1.0.7",
"@playkit-js/kaltura-player-js": "file:./playkit-js-kaltura-player-js-3.17.4.tgz",
"@playkit-js/kaltura-player-js": "file:./playkit-js-kaltura-player-js-3.17.7.tgz",
"@playkit-js/playkit-js": "^0.84.3-canary.0-22c594e",
"@types/chai": "^4.3.3",
"@types/mocha": "^9.1.1",
Expand Down
Binary file removed playkit-js-kaltura-player-js-3.17.4.tgz
Binary file not shown.
Binary file added playkit-js-kaltura-player-js-3.17.7.tgz
Binary file not shown.
2 changes: 1 addition & 1 deletion src/components/player-area/player-area-provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component, h, Fragment} from 'preact';
import {connect} from 'react-redux';
import {withLogger, WithLoggerProps} from '../logger';
import {StylesStoreAdapter} from './styles-store-adapter';
import {KPUIAddComponent, KPUIComponent, KPUIRemoveComponent} from '@playkit-js/kaltura-player-js';
import { KPUIAddComponent, KPUIComponent } from "../../types";

type PlayerAreaProviderProps = {
activePresetName?: string;
Expand Down
4 changes: 2 additions & 2 deletions src/components/player-area/player-area.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {h, Component, toChildArray, Fragment, VNode, ComponentChild, ComponentChildren} from 'preact';
import {connect} from 'react-redux';
import {withLogger} from '../../components/logger';
import {KPUIComponent} from '@playkit-js/kaltura-player-js';
import {withLogger} from "../logger";
import { KPUIComponent } from "../../types";

/**
* mapping state to props
Expand Down
2 changes: 2 additions & 0 deletions src/middlewares/logger.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @flow
/* eslint-disable no-unused-vars */
import getLogger from '../utils/logger';
import {UIOptionsObject} from '../types';

Expand Down
2 changes: 2 additions & 0 deletions src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ export * from './user-theme';
export * from './vr-stereo-config';
export * from './watermark-config';
export * from './reducers/root-state';
export * from './ui-component';
export * from './ui-component-options';
Loading

0 comments on commit 1a5779a

Please sign in to comment.