-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FEC-11520): Multi dropdowns are openable in cvaa overlay #638
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
449462d
fix(FEC-11520): Multi dropdowns are openable in cvaa overlay
fbd62f2
fix lint
cd0b1ee
fix
ca41d91
fix lint
1d7a503
revert
a24a5df
merge master
a6c82a9
different approach
06572b7
remove on close event props
aaf92b9
fix lint
b09ec92
back to the first solution
76a1319
Merge branch 'master' into FEC-11520
c54b836
back to the second solution
7e44706
set dropdwonid to private
06d67fa
return to the first solution with twist
3784b46
flow fix
5255335
add comment
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the side effects of removing the stopPropagation? we have additional click handlers that we wouldn't want them to catch the event.
As only drop down is using the menu maybe we can lift the event listener up to dropdown and expose the handler as a callback prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonathanTGold ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you mean to the click outside event i did lift it up and now it is managed from the dropdwon, But that in itself is not enough, the challenge is to distinguish between an event that comes from the current component and the rest and i did it by compering the event timestamps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OrenMe @JonathanTGold we need to remove the
stopPropagation
for closing the other menus. I think it's safe as it has been added after the UI already had most of the click handlers. of course, we have to verify it after this change.And I prefer the simple timeout solution rather than this event mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your call @yairans