Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11520): Multi dropdowns are openable in cvaa overlay #638

Merged
merged 16 commits into from
Oct 14, 2021
Merged

fix(FEC-11520): Multi dropdowns are openable in cvaa overlay #638

Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
449462d
fix(FEC-11520): Multi dropdowns are openable in cvaa overlay
Sep 11, 2021
fbd62f2
fix lint
Sep 12, 2021
cd0b1ee
fix
Sep 13, 2021
ca41d91
fix lint
Sep 13, 2021
1d7a503
revert
Sep 29, 2021
a24a5df
merge master
Sep 29, 2021
a6c82a9
different approach
Sep 29, 2021
06572b7
remove on close event props
Sep 30, 2021
aaf92b9
fix lint
Oct 3, 2021
b09ec92
back to the first solution
Oct 13, 2021
76a1319
Merge branch 'master' into FEC-11520
Oct 13, 2021
c54b836
back to the second solution
Oct 13, 2021
7e44706
set dropdwonid to private
Oct 13, 2021
06d67fa
return to the first solution with twist
Oct 14, 2021
3784b46
flow fix
Oct 14, 2021
5255335
add comment
Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/components/dropdown/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,11 @@ class DropDown extends Component {
/**
* on click handler
*
* @param {Event} e - keyboard event
* @returns {void}
* @memberof DropDown
*/
onClick = (e: Event): void => {
e.stopPropagation();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the side effects of removing the stopPropagation? we have additional click handlers that we wouldn't want them to catch the event.
As only drop down is using the menu maybe we can lift the event listener up to dropdown and expose the handler as a callback prop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonathanTGold ?

Copy link
Contributor Author

@JonathanTGold JonathanTGold Sep 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you mean to the click outside event i did lift it up and now it is managed from the dropdwon, But that in itself is not enough, the challenge is to distinguish between an event that comes from the current component and the rest and i did it by compering the event timestamps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrenMe @JonathanTGold we need to remove the stopPropagation for closing the other menus. I think it's safe as it has been added after the UI already had most of the click handlers. of course, we have to verify it after this change.
And I prefer the simple timeout solution rather than this event mechanism.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call @yairans

this.toggleDropDown();
onClick = (): void => {
setTimeout(() => this.toggleDropDown());
};

/**
Expand Down