fix(FEC-11510): No default font size selected in cvaa #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2021
yairans
reviewed
Sep 13, 2021
| @@ -62,9 +62,9 @@ class CustomCaptionsWindow extends Component { | |||
| const standardColors = player.TextStyle.StandardColors; | |||
|
|
|||
| const fontScaleOptions = player.TextStyle.FontSizes.map(scale => ({ | |||
There was a problem hiding this comment.
Suggested change
| const fontScaleOptions = player.TextStyle.FontSizes.map(scale => ({ | |
| const fontSizeOptions = player.TextStyle.FontSizes.map(size => ({ |
SivanA-Kaltura
changed the title
yairans
approved these changes
Sep 13, 2021
SivanA-Kaltura
added a commit
to kaltura/playkit-js
that referenced
this pull request
Sep 13, 2021
Modify default font size to 100%. Remove uses of fontScale and expose fontSize in API. Fixes FEC-11510. Related PRs: kaltura/playkit-js-ui#639. kaltura/kaltura-player-js#491
SivanA-Kaltura
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Sep 13, 2021
Remove references to fontScale to match changes in playkit-js. Fixes FEC-11510. Related PRs: kaltura/playkit-js#603 kaltura/playkit-js-ui#639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Use fontSize instead of fontScale.
Fixes FEC-11510.
Related PRs:
kaltura/playkit-js#603
kaltura/kaltura-player-js#491
CheckLists