fix(FEC-11707): V3 - cast on multiple players - when casting started by some player, "Cast" buttons become enabled on all players #642
Conversation
src/components/cast/_cast.scss
Outdated
| .cast-button:hover { | ||
| --disconnected-color: #{$white}; | ||
| --connected-color: #{$brand-color}; | ||
| .cast-button.cast-button-active { |
There was a problem hiding this comment.
can move this to the .player block? and just use .cast-button-active ?
There was a problem hiding this comment.
I can use &.cast-button-active inside the cast-button block, is that what you mean ?
wanted to separate because it seemed more readable but not critical
src/components/cast/_cast.scss
Outdated
| --connected-color: #{$brand-color}; | ||
| .cast-button.cast-button-active { | ||
| --connected-color: rgba(1, 172, 205, 0.8); | ||
| --disconnected-color: #{$grayscale4}; |
There was a problem hiding this comment.
why is needed? same for hover
There was a problem hiding this comment.
why is what needed ?
There was a problem hiding this comment.
--disconnected-color: #{$grayscale4}; already set
There was a problem hiding this comment.
oh, you're right
| @@ -73,6 +73,7 @@ class Cast extends Component { | |||
| */ | |||
| render(props: any): ?React$Element<any> { | |||
| if (props.isCasting || props.isCastAvailable) { | |||
| const className = props.isCasting ? `${style.castButton} ${style.castButtonActive}` : style.castButton; | |||
There was a problem hiding this comment.
| const className = props.isCasting ? `${style.castButton} ${style.castButtonActive}` : style.castButton; | |
| const className = props.isCasting ? [style.castButton, style.castButtonActive].join(' ') : style.castButton; |
we used to write it like this
There was a problem hiding this comment.
I think template string is more readable than using join()
There was a problem hiding this comment.
better to be aligned but not critical
There was a problem hiding this comment.
I care more about readability :)
Description of the Changes
Change cast button styles so that cast button would be highlighted only in actively casting player.
Fixes FEC-11707.
CheckLists