Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13234): Watermark - screen reader - Unlabelled image is shown on the watermark area #778

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix(FEC-13234): Watermark - screen reader - Unlabelled image is shown on the watermark area #778

merged 1 commit into from
Aug 7, 2023

Conversation

semarche-kaltura
Copy link
Collaborator

Description of the Changes

resolves: https://kaltura.atlassian.net/browse/FEC-13234

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

lianbenjamin
lianbenjamin approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@lianbenjamin lianbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add the "Watermark" to other i18n files?

@semarche-kaltura semarche-kaltura merged commit 7f1aa52 into master Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semarche-kaltura @lianbenjamin @SivanA-Kaltura