Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13506): Add Captions language selector in bottom bar #871

Merged
merged 5 commits into from
Jun 23, 2024

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Mar 27, 2024

Description of the Changes

Add Captions language selector in bottom bar

Resolves FEC-13506

@JonathanTGold JonathanTGold requested a review from a team March 27, 2024 16:07
JonathanTGold added 2 commits March 28, 2024 11:02
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Mar 28, 2024
@JonathanTGold JonathanTGold self-assigned this May 22, 2024
@JonathanTGold JonathanTGold changed the title feat(FEC-13728): Add Captions language selector in bottom bar feat(FEC-13506): Add Captions language selector in bottom bar May 22, 2024
@JonathanTGold JonathanTGold merged commit 52fc63a into master Jun 23, 2024
11 checks passed
JonathanTGold pushed a commit that referenced this pull request Jun 25, 2024
JonathanTGold added a commit that referenced this pull request Jun 25, 2024
### Description of the Changes


 fix  #871 PR regression

#### Resolves FEC-13506

Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
JonathanTGold added a commit that referenced this pull request Jul 10, 2024
#905)

### Description of the Changes

founding: 

- it is not a reggaeton - it is reproduced on
[0.79.2](7c7d4db)
as well (prior to
[#871)](#871) PR ) on any
dropdown menu click

- ti is happen only when the menu items on menu component are of a huge
number that overflowing that player size

- it is caused by the focus element that triggers on Menu Component
mount from the Al11y wrapper that wraps the Menu component

#### Resolves FEC-14034

Co-authored-by: JonathanTGold <jonathan.gold@86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants