fix(ADA-1275): When user focuses the player he will be able to play/pause with "space" key #907
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause with "space" key
RazvanBrinzoiK05
requested review from
MosheMaorKaltura,
semarche-kaltura,
JonathanTGold,
lianbenjamin,
SivanA-Kaltura and
Tzipi-kaltura
semarche-kaltura
requested changes
Aug 1, 2024
semarche-kaltura
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
After the pre-playback-overlay is rendered, with the centered big play button shown in the player container, the user can use it to start the playback and make the overlay component disappear. Afterwards he can play/pause the media by pressing "Space" key due to the fact that initially the play/pause button is focused.
The issue appears when the user switches focus from the player and returns to it, because the play button will not be focused anymore.
Fix:
Added event listener on the player container for the space key.