fix(ADA-1383): [Strategic Blue / University of Sheffield] - HD label on V7 player Settings button #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on V7 player Settings button
…on V7 player Settings button
Tzipi-kaltura
requested review from
JonathanTGold,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Jul 30, 2024
SivanA-Kaltura
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Issue:
When the quality is HD/4k/8k, there is quality icon on the settings button, but there is no indication for screen reader users to the quality state.
Fix:
Add additional string to the aria-label to inform about the quality.
Resolves ADA-1383