ADA-1499 - Make aria label equal to logo title #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinStoicaK
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Jul 31, 2024
SivanA-Kaltura
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
For the Logo link the SR was not announcing a meaningful description. The code was modified so that the message announced can now be customized by the client by modifying the Logo Title.
Issue:
Logo link aria-label is not meaningful
Fix:
Logo link aria-label is equal to the logo title or absence with a default title
Resolves https://kaltura.atlassian.net/browse/ADA-1499