Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-14156): quiz overlay behind cvaa freezes #948

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Sep 24, 2024

Description of the Changes

bugfix

Issue:
when opening the cvaa (advanced captions settings) while the video is playing and the video reaches a quiz question cue point, then closing the cvaa overlay- the quiz question overlay stays on the player and there is no way to close it.
the root cause is that closing the cvaa causes the removal of overlay-active class, which causes the odd behavior of the quiz question overlay.

Fix:

  • do not remove the overlay-active class if overlayPortal component has multiple children- remove it only if there's a single child
  • create a reusable getOverlayPortalElement function which returns the overlayPortal element
  • use getOverlayPortalElement function in other components
  • expose getOverlayPortalElement function for a future use outside of core scope

Resolves FEC-14156

@lianbenjamin lianbenjamin merged commit 25ab3f2 into master Sep 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants