fix(FEC-14156): quiz overlay behind cvaa freezes #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
bugfix
Issue:
when opening the cvaa (advanced captions settings) while the video is playing and the video reaches a quiz question cue point, then closing the cvaa overlay- the quiz question overlay stays on the player and there is no way to close it.
the root cause is that closing the cvaa causes the removal of overlay-active class, which causes the odd behavior of the quiz question overlay.
Fix:
overlay-active
class ifoverlayPortal
component has multiple children- remove it only if there's a single childgetOverlayPortalElement
function which returns theoverlayPortal
elementgetOverlayPortalElement
function in other componentsgetOverlayPortalElement
function for a future use outside of core scopeResolves FEC-14156