fix(ADA-1593): shift focus to seekbar when playing/pausing media within small width players #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in small width players
…in small width players
…in small width players
|
@Lkaltura Please fix the conflicts with the master, update the title (the title is not that important, but just to make sure that the squashed commit name will be in the correct format). Also please add a description in the future because it helps understand the scope of the change. |
Lkaltura
changed the title
SivanA-Kaltura
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusting the 'playerSize check' order to be executed after the event listener for first_play
and referring directly to this.props.playerSize instead of destructuring it from the props, as its value changes after the component is mounted, and we require the updated size.