fix(ADA-17): Playback button labels are generic and not video specific #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
SivanA-Kaltura,
semarche-kaltura and
lianbenjamin
SivanA-Kaltura
requested changes
Nov 4, 2024
src/components/pre-playback-play-overlay/pre-playback-play-overlay.tsx
Outdated
Show resolved
Hide resolved
lianbenjamin
requested changes
Nov 6, 2024
src/components/pre-playback-play-overlay/pre-playback-play-overlay.tsx
Outdated
Show resolved
Hide resolved
SivanA-Kaltura
approved these changes
Nov 7, 2024
lianbenjamin
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
When multiple players are embedded in single page, the screen reader's element list does not identify which button related to which player.
Fix:
Adding the entry name to the aria-label of play, pause, start over buttons
Resolves ADA-17