ADA(ADA-1451): Close Video Info modal dialog focus management #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
semarche-kaltura
approved these changes
Nov 13, 2024
Tzipi-kaltura
added a commit
to kaltura/playkit-js-ui-managers
that referenced
this pull request
Nov 19, 2024
create function to select the more plugin button from right controls elements. part of: kaltura/playkit-js-ui#958 kaltura/playkit-js-info#106 solves ADA-1451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
if user open the info plugin from more plugin, when press enter on x the focus is lost and doesn't move to the more plugin
Root cause:
The previous element is the dropdown info div from the more dropdown and not the the more button
Fix:
Create a reference of more plugin (we set it from the info plugin) and in case the previous element is dropdown item (of the more), move the focus to more plugin.
part of:
kaltura/playkit-js-ui-managers#67
kaltura/playkit-js-info#106
Resolves ADA-1451