-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUP-20681: fix Zoom 'expire_in' incorrect calculation + small refactor #9139
Conversation
$expiresIn = $tokensData[self::EXPIRES_IN]; | ||
$tokensData[self::EXPIRES_IN] = self::getValidUntil($expiresIn); | ||
return self::extractTokensFromData($tokensData); | ||
return $tokensData; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to return
*/ | ||
public static function getValidUntil($expiresIn) | ||
public static function setTokenExpiryAbsoluteTime($tokenData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call by ref
* @param array $tokenData | ||
* @return array $tokenData | ||
*/ | ||
public static function setTokenExpiryRelativeTime($tokenData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call by ref
@MosheMaorKaltura tested Zoom after adding "retrieveTokenData()" - works like a charm |
No description provided.