PLAT-10694: Add linux batch for doc conversion #9194
Conversation
| [KAsyncConvertPdfLinux : KAsyncConvertWorker] | ||
| id = 73 | ||
| friendlyName = ConvertPdfLinux | ||
| filter.jobSubTypeIn = 202 |
There was a problem hiding this comment.
isn't job sub type 202 already used used for KAsyncConvertPDF
There was a problem hiding this comment.
It should be full compatible with 202 on windows encoders.
| [KAsyncConvertPdfLinux : KAsyncConvertWorker] | ||
| id = 73 | ||
| friendlyName = ConvertPdfLinux | ||
| filter.jobSubTypeIn = 202 |
There was a problem hiding this comment.
It should be full compatible with 202 on windows encoders.
|
|
||
|
|
||
| //Linux | ||
| if ($constructorArgs['params']->osType == self::OS_TYPE_LINUX) |
There was a problem hiding this comment.
text comparison in php must be ===
| protected function getKillPopupsPath() | ||
| { | ||
| return NULL; | ||
| } |
| $tmpFile = kFile::replaceExt(basename($realInFilePath), 'pdf'); | ||
| $tmpFile = dirname($this->outFilePath).'/'.$tmpFile; | ||
| } | ||
| $tmpFile = kFile::replaceExt(basename($realInFilePath), 'pdf'); |
There was a problem hiding this comment.
Read only functionality has been removed here - I see no reason for that, especially when it is not effecting the linux convertor.
| unlink($killPopupsPath); | ||
|
|
||
| } | ||
|
|
||
| // Test file type | ||
| $errorMsg = $this->checkFileType($realInFilePath, $this->SUPPORTED_FILE_TYPES); |
There was a problem hiding this comment.
Since your new worker may encounter un supported file types, in case that error is returned and file type is not supported, job must be stopped with Error, so we can monitor it and understand that we need to fix it.
|
reviewed |
This change is