PLAT-10697:fixing categories fields search when converting KalturaMediaEntryFilter to esearch #9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iaEntryFilter to esearch
…iaEntryFilter to esearch
…iaEntryFilter to esearch
| $innerSearchItems = array(); | ||
| foreach ($values as $value) | ||
| { | ||
| if (!$statuses) |
There was a problem hiding this comment.
add to the function signature status=array(null)
remote this check
| } | ||
| } | ||
|
|
||
| protected function getCategoryOperator($elasticFieldName, $elasticFieldNamePairing, $value, $status = null) |
There was a problem hiding this comment.
use array of fieldNames
| @@ -252,6 +285,44 @@ protected function AddFieldPartToQuery($searchItemType, $elasticFieldName, $fiel | |||
| $this->addToSearchItemsByField($elasticFieldName, $searchItem); | |||
| } | |||
|
|
|||
| protected function addCategoryMultiQuery($elasticFieldName, $elasticFieldNamePairing, $fieldValue, $operatorType, $statuses = null) | |||
There was a problem hiding this comment.
Move the code to derived object for entry
| } | ||
| } | ||
|
|
||
| protected function getCategoryOperator($elasticFieldName, $elasticFieldNamePairing, $value, $status = null) |
| protected function getCategoryOperator($elasticFieldName, $elasticFieldNamePairing, $value, $status = null) | ||
| { | ||
| $searchItem = $this->addSearchItem($elasticFieldName, $value, ESearchItemType::EXACT_MATCH, false, $status); | ||
| $searchItemPairing = $this->addSearchItem($elasticFieldNamePairing, $value, ESearchItemType::EXACT_MATCH, false, $status); |
| @@ -288,41 +359,34 @@ protected function addSearchItem($elasticFieldName, $value, $itemType, $range = | |||
| return $searchItem; | |||
| } | |||
|
|
|||
| protected function getSearchItemForCategories($values, $searchType) | |||
| protected function handleFullNameCategory($elasticFieldName, $fieldValue, $operatorType) | |||
| @@ -288,41 +359,34 @@ protected function addSearchItem($elasticFieldName, $value, $itemType, $range = | |||
| return $searchItem; | |||
| } | |||
|
|
|||
| protected function getSearchItemForCategories($values, $searchType) | |||
| protected function handleFullNameCategory($elasticFieldName, $fieldValue, $operatorType) | |||
There was a problem hiding this comment.
remove elasticFieldName, operatorType
| @@ -288,41 +359,34 @@ protected function addSearchItem($elasticFieldName, $value, $itemType, $range = | |||
| return $searchItem; | |||
| } | |||
|
|
|||
| protected function getSearchItemForCategories($values, $searchType) | |||
| protected function handleFullNameCategory($elasticFieldName, $fieldValue, $operatorType) | |||
There was a problem hiding this comment.
rename - gtFullNameSearchOperator
| { | ||
| $innerSearchItems = array(); | ||
| $values = $this->createValuesArray($fieldValue); | ||
| if(count($values)) |
| $innerSearchItems = array(); | ||
| foreach ($values as $value) | ||
| { | ||
| if(substr($value, -1) == '>') //value is parent, we should retrieve entries that doesn't belong directly to this category - but only to the sub categories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is