Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10838: add entry server node id to the m3u8 url as sessionId #9380

Merged
merged 1 commit into from
May 5, 2020

Conversation

Amirhalfon1
Copy link
Contributor

@Amirhalfon1 Amirhalfon1 commented Apr 30, 2020

  • add entry server node id to the m3u8 url in case of MediaServerNode of type LiveCluster.
  • change getHttpUrl function in DeliveryProfileLive.php to receive entryServerNode instead of serverNode

This change is Reviewable

- add entry server node id to the m3u8 url in case of MediaServerNode of type LiveCluster.
- change getHttpUrl function in DeliveryProfileLive.php to receive entryServerNode instead of serverNode
@@ -354,7 +355,10 @@ protected function getLivePackagerUrl($serverNode, $streamFormat = null)
$entryId = $this->getDynamicAttributes()->getEntryId();
}

$livePackagerUrl = "$livePackagerUrl/p/$partnerID/e/$entryId/" . $serverNode->getSegmentDurationUrlString($segmentDuration);
$livePackagerUrl = "$livePackagerUrl/p/$partnerID/e/$entryId/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance in the future that we'll want both segmentDurationUrlString and sessionIdUrlString on the same url?
Isn't it always one or the other? seems like there should be one call and the relevant serverNode will handle it accordingly.

Copy link
Contributor

@david-winder-kaltura david-winder-kaltura Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct - currently, one is for the old live and the other for the new - but, can it be that in the future we will have server that need them both? yes
we wonder if the wrap both as one function of get extraParams or something - then each server will call all his related function - but then we will need to change the wowza-serverNode code, I prefer the avoid that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to leave the legacy code untouched I guess.

@Amirhalfon1 Amirhalfon1 changed the base branch from Propus-16.1.0 to Propus-16.2.0 May 4, 2020 06:58
@Amirhalfon1 Amirhalfon1 merged commit 51fbc6f into Propus-16.2.0 May 5, 2020
@Amirhalfon1 Amirhalfon1 deleted the Propus-16.0.1-PLAT-10838 branch May 5, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants