PLAT-10892: return s3 file location or local server file path for path only requests coming from s3 supported packager #9419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h only requests coming from s3 supported apckager
… if all flavor exist locally
| { | ||
| // if the entry fully exist locally return empty fileSync and path | ||
| // to make the request redirected for local serving | ||
| if(self::entryFullyExistLocally($flavorAsset->getEntryId())) |
There was a problem hiding this comment.
check the opposite that none exist in the $preferredStorageId
| else | ||
| { | ||
| // use cloud file location | ||
| $path = self::CLOUD_S3_PREFIX . $fileSync->getFilePath(); |
There was a problem hiding this comment.
Try to get the prefix from the remote storage
| * @return string | ||
| * @throws Exception | ||
| */ | ||
| public static function getPathByFileSync($fileSync) |
There was a problem hiding this comment.
If the preferred storage ID is not local - user URL else user file.
| { | ||
| $allowRemotePath = false; | ||
| if(!$local) | ||
| $file_sync = kFileSyncUtils::getFileSyncByPreferredOrder($syncKey, $flavorAsset, $preferredStorageId); |
There was a problem hiding this comment.
Rename - no Order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is