Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NFT examples with WASM and a Worker. #18

Merged
merged 18 commits into from
Jan 5, 2020

Conversation

kalwalt
Copy link
Owner

@kalwalt kalwalt commented Jan 4, 2020

This is the continues of PR #7.
Add at least one example with WASM and a Worker. It should improve fps of 10/15%.

@kalwalt kalwalt added enhancement New feature or request javascript all about javascript code code design labels Jan 4, 2020
@kalwalt kalwalt self-assigned this Jan 4, 2020
@kalwalt kalwalt added the NFT nft markerless technology label Jan 4, 2020
@kalwalt
Copy link
Owner Author

kalwalt commented Jan 4, 2020

  • First: I'm not sure if it make sense the video_threejs_wasm_worker.html example, i think i will delete it because it' is not necessary, it don't works properly and i don't want to spend my time resolving this.

  • Second: these examples use another type of worker (nft/wasm_worker.js) inside a nft folder I'm thinking to find a solution to integrate the two versions.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 4, 2020

Question: the flag ' -s BINARYEN_TRAP_MODE=clamp' should be added to all the libs or only for the WASM version?

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 5, 2020

With the last commit d10de2e i don't include the video + wasm + worker example.
@nicolocarpignoli The artoolkit.wasm_worker.js is inside the wasm_worker folder because i can not configure a right path for:

var artoolkit_wasm_url = 'artoolkit_wasm.wasm';

if i set the path to point to the wasm lib inside the build folder it fails to load.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 5, 2020

I added the flag -s BINARYEN_TRAP_MODE=clamp only to the WASM lib with this commit 1bb7a0f, though the other libs are the same. This means that probably this flag is ignored for the compilation of the .min and .debug libs (compiled with asm)

@kalwalt kalwalt merged commit f566a50 into fixing-nft Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code design enhancement New feature or request javascript all about javascript code NFT nft markerless technology
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant