Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Output flag to save separate generated nix for overridding in default.nix #10

Closed
wants to merge 1 commit into from

Conversation

kamilchm
Copy link
Owner

@kamilchm kamilchm commented Mar 8, 2016

No description provided.

@cstrahan
Copy link

cstrahan commented Mar 9, 2016

I think this is great step in the right direction, but I think there are still a few nits. When I wrap up work tonight, I'll have more constructive feedback, and might push up branch that's based 90% on this, plus a few changes.

@cstrahan
Copy link

Is there any reason not to use buildFromGitHub for go packages hosted on GitHub?

@kamilchm
Copy link
Owner Author

It was simple to start with fetch + vcs without any conditional branches.
Using fetchFromGithub could be the next improvement after we find a base form for easy overridable derivations.

@kamilchm
Copy link
Owner Author

One more thought. Maybe we don't need any nix specific tool and we could use godep json from nix, eg.:

extraSrcs = stdenv.lib.importJSON ./Godeps/Godeps.json;

What do you think?

@kamilchm
Copy link
Owner Author

Wrong, godep doesn't produce checksums for dependencies :/

@zimbatm
Copy link

zimbatm commented Mar 14, 2016

Is there any way to use intentional dependencies in the nix store ? I think that we can trust git commit ids to be unique.

@kamilchm
Copy link
Owner Author

You mean, searching dependencies in nix store and reuse it?

@zimbatm
Copy link

zimbatm commented Mar 15, 2016

I mean if we could use the git sha key as the store key then we wouldn't have to calculate the checksum of the git folder. Right now it's a bit redundant to have both checksums if we trust git to always return the same data.

It looks like it's not implemented though: NixOS/nix#296

@kamilchm
Copy link
Owner Author

buildGoPackage can use json files for dependencies like in https://github.com/NixOS/nixpkgs/blob/7d02cc1dd50766058b2ec2c6d3a741d96db5d27b/doc/languages-frameworks/go.xml and go2nix master supports this new format.

@kamilchm kamilchm closed this Jun 11, 2016
@kamilchm kamilchm deleted the overridable-nix branch September 30, 2016 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants