Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for kiritan & ofuton_p_utagoe db (singing voice synthesis) #330

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

PeterGuoRuc
Copy link
Contributor

@PeterGuoRuc PeterGuoRuc commented Feb 11, 2022

Hi, This recipe intends for training vocoder for singing voice synthesis on kiritan & ofuton_p_utagoe dataset. The vocoder can be directly used in Muskits, open-source singing voice synthesis toolkits https://github.com/SJTMusicTeam/Muskits. Pre-trained models will be uploaded to google drive soon.
Please check to see if there is anything that needs to be modified. @ftshijt @kan-bayashi

@kan-bayashi
Copy link
Owner

@PeterGuoRuc Thank you for your contribution! I will review today!

Copy link
Owner

@kan-bayashi kan-bayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency of the naming, could you rename kiritan -> kiritan_db?

@ftshijt
Copy link
Contributor

ftshijt commented Feb 17, 2022

Hi @kan-bayashi , we name the recipe based on the convention of its source. While the db is regarded as the official name for both the oniku and ofuton (they are also from the same source with many overlapped songs), Kiritan seems to be a bit independent.

In addition, we would be appreciated if following the convention in our Muskit toolkit as well (i.e., https://github.com/SJTMusicTeam/Muskits

@kan-bayashi
Copy link
Owner

OK, I see! Then that is no problem.

@kan-bayashi kan-bayashi merged commit fe8e965 into kan-bayashi:master Feb 18, 2022
@kan-bayashi
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants