Final (?) perl improvements #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Representing a keyword as a Mal::String with a magic first character was beginning to annoy me, so instead create a proper Mal::Keyword class. To support using both Mal::String and Mal::Keyword as hash keys, overload stringification on all Mal::Scalar subclasses. This means that now instead of a Mal::String stringifying to something like "Mal::String=SCALAR(0x5744ea58)", it will stringify to something more like "Mal::String abc", which is readable, has the correct properties for a hash-map key, and is easy to convert back into a Mal::String. This turns out to work perfectly well, and entirely accidentally arranges that 'keyword' now works properly when fed a keyword as input.
This means that most of the special forms have an assignment at the top giving names to the members of @$ast. I think this makes the code a little more readable.
I feel that it's more perly to directly use Perl's array manipulation functions. It's certainly more consistent with the other special forms.
I don't think it's worked on perl 5.8 for a long time.
|
Looks good. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've reached the point where the changes I'm making to the perl implementation aren't actually making it any better, so here are the lest few that I think are actually good. I found a nicer way to implement keywords, eliminated the numbered variables in the special form switch, and documented things a little.