Callback Support (alternative implementation)#908

Open

RebeccaStevens wants to merge 68 commits intokangax:gh-pagesfrom RebeccaStevens:callback-support-alt

+2,036-1,357

Commits on Apr 12, 2018

Added tests.
Rebecca Stevens
committed
Added callback parameter to minify.
Rebecca Stevens
committed
Added callback parameter to minifyCSS and minifyJS.
Rebecca Stevens
committed
Create a placeholder class for async text.
Rebecca Stevens
committed
When processing entries in the buffer, make sure they are a string.
Rebecca Stevens
committed
The result is only finalize and returned if there are no async tasks running.
Rebecca Stevens
committed
Set up minifyJS and minifyCSS to be able to complete asynchronously.
Rebecca Stevens
committed
Added error handling.
Rebecca Stevens
committed
Removed extra empty lines.
Rebecca Stevens
committed
"along side" --> "alongside"
Rebecca Stevens
committed
Added extra check to 'minify error with callback' test.
Rebecca Stevens
committed
Added a test to ensure the minifyCSS and miniftJS callbacks can only be called once.
Rebecca Stevens
committed
Fixed bug with AsyncTextPlaceholder not being able to have the emptyString as its value.
Rebecca Stevens
committed
Fixed bug with error not being given to callback after all async tasks have completed.
Rebecca Stevens
committed
Added callback information to the readme.
Rebecca Stevens
committed
Refactored.
RebeccaStevens
committed

Commits on Apr 13, 2018

Refactored - Async tasks now do not start until after all sync code has finished.
Rebecca Stevens
committed
Added inline callback tests.
Rebecca Stevens
committed

Commits on Apr 18, 2018

All test now test both synchronously and asynchronously.
Rebecca Stevens
committed
Merge branch 'gh-pages' into callback-support-alt
Rebecca Stevens
committed
Fix potential issue with placeholder not being at the same index it was put at when it comes to replacing it with content.
Rebecca Stevens
committed
Refactored.
Rebecca Stevens
committed
Asynchronously tests now give more helpful feedback when an error occurs.
Rebecca Stevens
committed
Created a test_minify_error function to test for expected errors.
Rebecca Stevens
committed
Fixed issue with code still executing after callback.
Rebecca Stevens
committed
Initial step to get normalizeAttr working with a callback.
Rebecca Stevens
committed
Fixed conversion from sync to async minifyJS and minifyCSS.
Rebecca Stevens
committed
Refactored.
Rebecca Stevens
committed

Commits on Apr 19, 2018

Merge branch 'gh-pages' into callback-support-alt
Rebecca Stevens
committed
Async start tasks now modifies the buffer inplace.
Rebecca Stevens
committed
removeStartTag and removeEndTag now take an indexBound which prevents modification to the buffer at or past its value.
Rebecca Stevens
committed
Added callbacks to more functions and wrapped them in AsyncTasks.
Rebecca Stevens
committed
squashTrailingWhitespace now uses indexBound.
Rebecca Stevens
committed

Commits on Apr 20, 2018

Fixed issue with bad error reporting when the minify function never calls it's callback.
Rebecca Stevens
committed
Removed placeholders as they are not necessary when everything will be a placeholder.
Rebecca Stevens
committed
Removed unneeded data object wraps.
Rebecca Stevens
committed
Tasks no longer have data associated with them.
Rebecca Stevens
committed
Moved 'isLast' into function loop to mimic original for loop scoping.
Rebecca Stevens
committed
Slight code style improvements.
Rebecca Stevens
committed
Added missing callbacks.
Rebecca Stevens
committed
Fixed bad implementation of cleanConditionalComment callback support.
Rebecca Stevens
committed
Removed already fixed fixme.
Rebecca Stevens
committed
Fixed issue with minifyCSS and minifyJS functions taking an error in their callback.
Rebecca Stevens
committed
Added async tests.
Rebecca Stevens
committed
Fixed up tests.
Rebecca Stevens
committed
Added 'callback called multiple times' tests.
Rebecca Stevens
committed

Commits on Apr 26, 2018

Removed async only option from test_minify.
Rebecca Stevens
committed
Refactored Task and TaskGroup.
Rebecca Stevens
committed
Fix issue with not all callbacks being in the form of (error, result).
Rebecca Stevens
committed
Moved typedefs below imports.
Rebecca Stevens
committed
Fixed 'Maximum call stack size exceeded' in the sync case.
Rebecca Stevens
committed
Removed sync callback tests. Callbacks are never sync now.
Rebecca Stevens
committed
Fixed 'Maximum call stack size exceeded' in the async case.
Rebecca Stevens
committed
Improved comment.
Rebecca Stevens
committed
Recovered from 'Maximum call stack size exceeded' error.
Rebecca Stevens
committed

Commits on Apr 27, 2018

Refactored
Rebecca Stevens
committed
The buffer can now recover from 'Maximum call stack size exceeded' error.
Rebecca Stevens
committed