Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.81 to match home@0.5.11 #461

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Dec 18, 2024

fido-hid-rs has a transitive build dependency on home:

% cargo tree -i home
home v0.5.9
└── which v4.4.2
    └── bindgen v0.65.1
        [build-dependencies]
        └── fido-hid-rs v0.5.0

This now fails in CI on rustc 1.79, which pulls in home@0.5.11:

error: rustc 1.79.0 is not supported by the following package:
  home@0.5.11 requires rustc 1.81
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.79.0

MSRV has been bumped by point releases in rust-lang/cargo#14867 and rust-lang/cargo#14871

home@0.5.9 is the last version to support rustc 1.79.

This would probably also be fixed by an MSRV-aware resolver.

FWIW home is "not intended for external use" .. and should use something like env-home: harryfei/which-rs#104

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@micolous micolous mentioned this pull request Dec 18, 2024
2 tasks
@micolous micolous marked this pull request as ready for review December 18, 2024 06:39
@yaleman yaleman enabled auto-merge (squash) December 18, 2024 06:44
@yaleman yaleman merged commit 7c4fbac into kanidm:master Dec 18, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants