Remove unused ArtifactCloudObject (#4218)

* Remove unused ArtifactCloudObject

* Remove CloudObjectProvider

pkg/apis/cr/v1alpha1/types.go

@@ -146,28 +146,7 @@ type Phase struct {
 
 // Artifact tracks objects produced by an action.
 type Artifact struct {
-	CloudObject ArtifactCloudObject `json:"cloudObject"`
-	KeyValue    map[string]string   `json:"keyValue"`
-}
-
-// CloudObjectProvider is the cloud storage provider.
-type CloudObjectProvider string
-
-const (
-	// CloudObjectProviderGCS means this provider is Google Cloud Storage.
-	CloudObjectProviderGCS CloudObjectProvider = "GCS"
-	// CloudObjectProviderS3 means this provider is AWS S3.
-	CloudObjectProviderS3 CloudObjectProvider = "S3"
-)
-
-// ArtifactCloudObject references an object in cloud storage.
-type ArtifactCloudObject struct {
-	Bucket   string              `json:"bucket"`
-	Provider CloudObjectProvider `json:"provider"`
-	Endpoint string              `json:"endpoint"`
-	Path     string              `json:"path"`
-	PathType string              `json:"pathType"`
-	Region   string              `json:"region"`
+	KeyValue map[string]string `json:"keyValue"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

pkg/validate/validate.go

@@ -117,14 +117,6 @@ func Blueprint(bp *crv1alpha1.Blueprint) error {
 	return nil
 }
 
-// CloudObjectProvider returns an error if op is not a known provider
-func CloudObjectProvider(op crv1alpha1.CloudObjectProvider) error {
-	if op != crv1alpha1.CloudObjectProviderGCS && op != crv1alpha1.CloudObjectProviderS3 {
-		return errorf("Invalid cloud object provider %s", op)
-	}
-	return nil
-}
-
 func ProfileSchema(p *crv1alpha1.Profile) error {
 	if p.Location.Type != crv1alpha1.LocationTypeS3Compliant {
 		return errorf("unknown or unsupported location type '%s'", p.Location.Type)

pkg/validate/validate_test.go

@@ -466,19 +466,3 @@ func (s *ValidateSuite) TestBlueprint(c *C) {
 	err := Blueprint(nil)
 	c.Assert(err, IsNil)
 }
-
-func (s *ValidateSuite) TestCloudObjectProvider(c *C) {
-	cases := []struct {
-		cop     crv1alpha1.CloudObjectProvider
-		checker Checker
-	}{
-		{crv1alpha1.CloudObjectProviderGCS, IsNil},
-		{crv1alpha1.CloudObjectProviderS3, IsNil},
-		{crv1alpha1.CloudObjectProvider(""), NotNil},
-		{crv1alpha1.CloudObjectProvider("unsupported provider"), NotNil},
-	}
-	for _, tc := range cases {
-		err := CloudObjectProvider(tc.cop)
-		c.Assert(err, tc.checker)
-	}
-}